-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Move some std tests to integration tests #135621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
This comment has been minimized.
This comment has been minimized.
cool. @bors r+ |
Not yet. There are a whole bunch more tests that need to be handled. These are just some of the easier ones that are just testing the public api. There are also a lot of tests of private api's for which I don't have a good solution yet. Once all those tests are moved however we can indeed remove all |
@bors r- I believe this failed in #135655
|
Thanks for the PR @bjorn3 ! We ran this PR on our internal CI for the SGX target and it fails with:
I believe this is caused by the following line in the
and that it should be changed to:
could you please make this change? Thank you! |
Just wanted to note, if it wasn't obvious why the error above happened, is that there are a bunch of One suggestion is to move the set_var ones to a separate integration test so they don't interfere. |
SGX should be fixed now. And I moved the set_var tests to a separate integration test. |
This comment has been minimized.
This comment has been minimized.
Awesome! :) |
@rustbot ready |
☔ The latest upstream changes (presumably #136085) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r- |
a56ecda
to
cc7e3a6
Compare
@bors r=Noratrieb |
Unit tests directly inside of standard library crates require a very fragile way of building that is hard to reproduce outside of bootstrap.
Follow up to #133859